Command Button is not functioning (1 Viewer)

KittyCat · Nov 25, 2016

Hello there,

I have an issue here where I cannot run my command button in VB Access. There is no error stated but the button just wont function.

Here is the code:

Private Sub Command14_Click()

Dim strOldPassword As String
Dim strSQL As String

strOldPassword = DLookup("[password]", "tblUser", "[LoginID] = '" & Me.List25 & "'")
Select Case strOldPassword
Case Is = Me.Text10
strSQL = "UPDATE tblUser SET Password=" & "'" & Me.Text10 & "' WHERE [LoginID] = " & " & Me.List25 & "
MsgBox "Password has been changed", vbInformation, "Password Changed"
Case Is <> Me.Text6
MsgBox "The Old Password does not match", vbInformation, "Type Correct Old Password"
End Select

End Sub

I also edit setting on Trust Center. But it won't run

Hope to get your assistance on this! Thank you.

moke123 · Nov 25, 2016

This line doesnt look right although it may work

Code:

strSQL = "UPDATE tblUser SET Password=" & "'" & Me.Text10 & "' WHERE [LoginID] = " & " & Me.List25 & "

try

Code:

strSQL = "UPDATE tblUser SET Password= """ &  Me.Text10  & """ WHERE  [LoginID] = """ &  Me.List25  & """"
currentdb.Execute strSQL, dbFailOnError

the reason your code doesnt work is you never execute the sql.

KittyCat · Nov 25, 2016

Still not functioning

Is it because of my query or my table? Because i use Email as my id.
hmm

JHB · Nov 25, 2016

KittyCat said:
..
Is it because of my query or my table? Because i use Email as my id.
hmm

Do you mean as LoginID?
If Me.List25 is a text value then try:

Code:

strSQL = "UPDATE tblUser SET Password= '" &  Me.Text10  & "' WHERE  [LoginID] = '" &  Me.List25  & "'"

KittyCat · Nov 25, 2016

Yes, text.
But the button stil not functioning. I put the incorrect old password (with my new password) and the button detects but when I insert correct old password (with new password), the button is not detecting.

Any idea?

Uncle Gizmo · Nov 25, 2016

Does the message box part return a message?

Sent from my SM-G925F using Tapatalk

Grumm · Nov 25, 2016

Maybe it is a good habit to name the controls with a meaningfully name.

Code:

Private Sub Command14_Click()

Dim strOldPassword As String
Dim strSQL As String

strOldPassword = DLookup("[password]", "tblUser", "[LoginID] = '" & Me.List25 & "'")
Select Case strOldPassword
Case Is = Me.Text10 [COLOR="Red"]// Is this the old password or the new ?[/COLOR]
strSQL = "UPDATE tblUser SET Password=" & "'" & Me.Text10 & "' WHERE [LoginID] = " & " & Me.List25 & "
MsgBox "Password has been changed", vbInformation, "Password Changed"
Case Is <> Me.Text6 [COLOR="Red"]// What field is this now ? What is the difference between Text10 and Text6 ?[/COLOR]
MsgBox "The Old Password does not match", vbInformation, "Type Correct Old Password"
End Select

End Sub

See text in red... There are 2 different input values, but you use only one to update the old password...

moke123 · Nov 25, 2016

Explain in simple terms exactly what you are trying to do.
Are you changing a password? It isn't clear, especially with control names which have no meaning.

moke123 · Nov 26, 2016

Heres a simple demo of a change password procedure since it appears that is what your aiming for. It uses StrComp() to compare the various password entries (old,new, and confirm new) and is case sensitive. It also records the date of change in case you wish to automate a renewal date.

KittyCat · Nov 29, 2016

moke123 said:
Heres a simple demo of a change password procedure since it appears that is what your aiming for. It uses StrComp() to compare the various password entries (old,new, and confirm new) and is case sensitive. It also records the date of change in case you wish to automate a renewal date.

Runtime error 2471 occurs.
Is it because of LoginID?
Cause LoginID is a text not number

strSql = "update tblUser set txtPassword = """ & Me.TxtNew & """, dteChanged = #" & Date & "# where LoginID = " & Me.cboUser & "'"

and

Me.TxtHint = "For demo purposes " & Me.cboUser.Column(1) & "'s old Password is " & DLookup("txtPassword", "tblUser", "LoginID = " & Me.cboUser & "'")

Grumm · Nov 29, 2016

You know that SQL doesn't use double quotes ?
You need to use single quotes when updating strings.
So you need :
strSql = "update tblUser set txtPassword = '" & Me.TxtNew & "', dteChanged = #" & Date & "# where LoginID = '" & Me.cboUser & "'"

Same in the DLookup. You are missing the first ' in "LoginID = '" & Me.cboUser & "'"

moke123 · Nov 29, 2016

You need to use single quotes when updating strings.

while a single quote will probably suffice for the OP's purposes seeing as they are using an email as an id, i generally prefer using double quotes to account for the possibilty of an apostrophe appearing in the string.

KittyCat · Nov 30, 2016

Thanks a lotmoke123 and Grumm!
The problem is now solved!

I'm happy now!

Grumm · Nov 30, 2016

I use single quotes for strings. I work all day with Microsoft SQL manager... If you try to use double quotes, the sql gives a nice error. But in Access you can use both.

But the problem of the OP's query was that he missed the first quote in this part :

Code:

where LoginID = " & Me.cboUser & "'"

Command Button is not functioning (1 Viewer)

KittyCat

New member

moke123

AWF VIP

KittyCat

New member

JHB

Have been here a while

KittyCat

New member

Uncle Gizmo

Nifty Access Guy

Grumm

Registered User.

moke123

AWF VIP

moke123

AWF VIP

KittyCat

New member

Grumm

Registered User.

moke123

AWF VIP

KittyCat

New member

Grumm

Registered User.

Similar threads

Users who are viewing this thread