Make code Shorter (1 Viewer)

stoicy · Feb 20, 2019

Hello Everybody

is it possible to make this code shorter!!

Code:

[Forms]![frmOrder]![frmOrderDetails].[Form]![AvaQu] = [Forms]![frmOrder]![frmOrderDetails].[Form]![AvaQu] - [Forms]![frmOrder]![frmOrderDetails].[Form]![ProQu]
Exit Sub
[Forms]![frmOrder]![frmOrderDetails].[Form]![AvaQu] = [Forms]![frmOrder]![frmOrderDetails].[Form]![AvaQu] + [Forms]![frmOrder]![frmOrderDetails].[Form]![RetQu]

frmOrder = Main Form
frmOrderDetails = Sub Form
AvaQu = Avaliable quantity of product in store
ProQu = Reqursted Quantity (Sales)
RetQu = Returned Quantity (Sales)

Thank you for usual support

Mark_ · Feb 20, 2019

Is this in the main form, the sub form, or some where else?

stoicy · Feb 20, 2019

Mark_ said:
Is this in the main form, the sub form, or some where else?

Sorry

I put it in sub form after update

I don't know if it is the right place

Sent from my SM-N900V using Tapatalk

MajP · Feb 20, 2019

If your repeat things, use a variable

Code:

Dim myFrm as access.form 'if frmorder is the current form then
set myFrm = me.frmOrderDetails.form
myFrm.avaqu = myfrm.avaqu-myfrm.proqu
exit sub
myfrm.avaqu = myfrm.avaqu + myfrm.retqu

stoicy · Feb 20, 2019

MajP said:
If your repeat things, use a variable

Code:

Dim myFrm as access.form 'if frmorder is the current form then set myFrm = me.frmOrderDetails.form myFrm.avaqu = myfrm.avaqu-myfrm.proqu exit sub myfrm.avaqu = myfrm.avaqu + myfrm.retqu

I put that code but an error message appears saying "Compile error Method or data member not found"

Sent from my SM-N900V using Tapatalk

MajP · Feb 20, 2019

I am basing this on some assumptions without seeing all the code, and not doing this in vba. Please take the concept and error checked what I typed. Where does the code break?

stoicy · Feb 20, 2019

Sorry I am not good with codes
See attached pic

Sent from my SM-N900V using Tapatalk

MajP · Feb 20, 2019

It appears that frmOrderDetails is not a subform control on the current form. If frmOrders is not the current from where the code is called then you cannot use Me. It would have to reference frmOrders

set myFrm = Forms!frmOrder.frmOrderDetails.Form

CJ_London · Feb 20, 2019

you could try

Code:

with [Forms]![frmOrder]![frmOrderDetails].[Form]
    ![AvaQu] =![AvaQu] - ![ProQu]
end with
Exit Sub

stoicy · Feb 20, 2019

Also not working

Sent from my SM-N900V using Tapatalk

stoicy · Feb 20, 2019

CJ_London said:
you could try

Code:

with [Forms]![frmOrder]![frmOrderDetails].[Form] ![AvaQu] =![AvaQu] - ![ProQu] end with Exit Sub

OK I will see now

Sent from my SM-N900V using Tapatalk

stoicy · Feb 20, 2019

CJ_London said:
you could try

Code:

with [Forms]![frmOrder]![frmOrderDetails].[Form] ![AvaQu] =![AvaQu] - ![ProQu] end with Exit Sub

This error see pic

Sent from my SM-N900V using Tapatalk

Gasman · Feb 20, 2019

Why not just write it as CJ_London posted?

CJ_London · Feb 20, 2019

what he said!

stoicy · Feb 20, 2019

Gasman said:
Why not just write it as CJ_London posted?

I thought it is like that
I don't know about codes
Sorry

Sent from my SM-N900V using Tapatalk

CJ_London · Feb 20, 2019

so did it work?

stoicy · Feb 20, 2019

CJ_London said:
so did it work?

No

Sent from my SM-N900V using Tapatalk

CJ_London · Feb 20, 2019

there is an assumption that your original 'long' code works - does it? and if not what error do you get? And what error are you getting with my suggestion?

I ask because normally you would use .[AvaQu] rather than ![AvaQu]

FYI most computers now have a 'snipping tool' to take screen shots of part of the screen - you might find that a lot easier than photographing it. Just click on the windows start button, bottom left of the screen and start typing 'snipping tool'

stoicy · Feb 20, 2019

CJ_London said:
there is an assumption that your original 'long' code works - does it? and if not what error do you get? And what error are you getting with my suggestion?

I ask because normally you would use .[AvaQu] rather than ![AvaQu]

FYI most computers now have a 'snipping tool' to take screen shots of part of the screen - you might find that a lot easier than photographing it. Just click on the windows start button, bottom left of the screen and start typing 'snipping tool'

Yes my code us working but through button.

I thought it will be shorter and to work after update in the subform.

Sent from my SM-N900V using Tapatalk

Cronk · Feb 20, 2019

I'll guess that there have been 2 forms created and saved as frmOrder and frmOrderDetails. Check the name of the subForm control in Properties in design mode. It will probably be Childx but it may have been renamed.

It's necessary to refer to the subform control name ie

Code:

forms!frmOrder.Childx.form.[AvaQu]

Make code Shorter (1 Viewer)

Registered User.

Longboard on the internet

Registered User.

You've got your good things, and you've got mine.

Registered User.

You've got your good things, and you've got mine.

Registered User.

You've got your good things, and you've got mine.

Super Moderator

Registered User.

Registered User.

Registered User.

Enthusiastic Amateur

Super Moderator

Registered User.

Super Moderator

Registered User.

Super Moderator

Registered User.

Registered User.

Similar threads

Users who are viewing this thread