Cleaning Code (1 Viewer)

[hllary]

I'm writing some code to hide the text box if the value is null. I have twenty text boxes.

I'm using the code below, but I was wondering if there is cleaner way of doing this.

Private Sub Form_Current()
If IsNull(Me.Text0) Then
    Me.Text0.Visible = False
    Else
    Me.Text0.Visible = True
    
End If

If IsNull(Me.Text1) Then
    Me.Text1.Visible = False
    Else
    Me.Text1.Visible = True
End If

If IsNull(Me.Text2) Then
    Me.Text2.Visible = False
    Else
    Me.Text2.Visible = True
End If

If IsNull(Me.Text3) Then
    Me.Text3.Visible = False
    Else
    Me.Text3.Visible = True
End If

If IsNull(Me.Text4) Then
    Me.Text4.Visible = False
    Else
    Me.Text4.Visible = True
End If

 

[plog]

IsNull resolves to True/False, so just use it on the right side of the equality instead of all the If/Elses:

Me.Text0.Visible = Not IsNull(Me.Text0)
Me.Text1.Visible = Not IsNull(Me.Text1)

 

[plog]

Sorry that was the big thing I saw. Since they are all named similarly you could wrap them in a loop and set them that way:

For i=0 to 20
Me.Controls("TextBox" & i).Visible = Not IsNull(Me.Controls("Textbox" & i)
Next

Above is psuedo code

 

[hllary]

Thank you!!

 

[Pat Hartman]

Before you write all this code, you might consider giving proper names to the controls.

 

[hllary]

Before you write all this code, you might consider giving proper names to the controls.

The names I used here were for this example. I have proper names in the database.