Dir Funtion?

[Tommy B]

Hi Guys,

Well I'm bumbling along with my vba and have had some success (mainly due to the patience and indulgance of fellow members ). However I have a hit a problem with the Dir function, I know I must be wrong but I would really appreciate somebody showing me the error of my ways.

I'm getting a type mismatch run-time error 13....can anyone explain what's wrong with my code?

Cheers,

Tommy B

Public sub test()
Dim retval


If Dir("C:\leads_folder\daily_declines\dailydone.txt") Then
Kill ("C:\leads_folder\daily_declines\dailydone.txt")
retval = shell("c:\leads_folder\daily_declines\dailyconversion(tom).bat", vbMinimizedFocus)
While Not Dir("C:\leads_folder\daily_declines\dailydone.txt", vbNormal)
Wend
End If
End Sub

 

[Shadez]

Dont worry its a easy mistake to make, the dir fucntion is a bit weird


try

If Dir("C:\leads_folder\daily_declines\dailydone.txt") Then 
Kill ("C:\leads_folder\daily_declines\dailydone.txt") 
retval = shell(" c:\leads_folder\daily_declines\dailyconversion(tom
).bat", vbMinimizedFocus) 
Do
        If Dir = "" Then
            Exit Do
            
        End If
Loop
End If 
End Sub

ShadeZ

 

[Tommy B]

Thank-You

Brilliant, thanks Shadez. Iwas close but no cigar

Thanks again for taking the time to help me out...much appreciated!

Cheers,

Tom.

 

[Shadez]

No probs.

 

[Peter D]

The Dir function doesn't return a True/False value. It returns an empty string, or the name of a file or folder. So try this:

If Dir("C:\leads_folder\daily_declines\dailydone.txt") <> "" Then
Kill ("C:\leads_folder\daily_declines\dailydone.txt")
retval = shell(" c:\leads_folder\daily_declines\dailyconversion(tom
).bat", vbMinimizedFocus)
While Dir("C:\leads_folder\daily_declines\dailydone.txt", vbNormal) = ""
Wend
End If
End Sub

Instead of using Shell and then looping for a file name, you may want to consider using Shell and Wait:

http://www.mvps.org/access/api/api0004.htm

Hope this helps,

 

[Shadez]

The Dir function doesn't return a True/False value. It returns an empty string, or the name of a file or folder. So try this:

If Dir("C:\leads_folder\daily_declines\dailydone.txt") <> "" Then
Kill ("C:\leads_folder\daily_declines\dailydone.txt")
retval = shell(" c:\leads_folder\daily_declines\dailyconversion(tom
).bat", vbMinimizedFocus)
While Dir("C:\leads_folder\daily_declines\dailydone.txt", vbNormal) = ""
Wend
End If
End Sub

Instead of using Shell and then looping for a file name, you may want to consider using Shell and Wait:

http://www.mvps.org/access/api/api0004.htm

Hope this helps,

You have been beaten to it by a good 3 hours,


Oh and nice infiate loop.