Run-time error 3134, Syntax error INSERT INTO (1 Viewer)

[murray83]

have this error as well and after a google search i ended up here, whod of guessed that, this forum is great

anyway here is my code

DoCmd.RunSQL ("INSERT INTO tbl_Returns ( Dt, Supplier, Reservation, PO, SKU, CaseCount, PalletCount, Reason, TrailerNumber, UserName, FLM, AddedBy, DtAdded )VALUES ( txtDT.value, txtSupplier.value, txtRef.value, txtPO.value, txtSKU.value, txtCaseCount.value, txtPalletCount.value, txtReason.value, txtTrailerNo.value,txtUser.value, txtFLM.value, txtWhoAdded.value, #" & txtDtAdded.Value & "#,)")

i have put the # mark and the & round my date value and both are formatted as short date but still says ol error 3134

 

[arnelgp]

With Currentdb.CreateQueryDefs("", "INSERT INTO tbl_Returns (Dt, Supplier, Reservation, " & _
                                    "PO, SKU, CaseCount, PalletCount, Reason, TrailerNumber, " & _
                                    "UserName, FLM, AddedBy, DtAdded) SELECT p0, p1, p2, p3, p4, " & _
                                    "p5, p6, p7, p8, p9, p10, p11, p12;")
    .Parameters(0) = txtDT.value
    .Parameters(1) = txtSupplier.value
    .Parameters(2) = txtRef.value
    .Parameters(3) = txtPO.value
    .Parameters(4) = txtSKU.value
    .Parameters(5) = txtCaseCount.value
    .Parameters(6) = txtPalletCount.value
    .Parameters(7) = txtReason.value
    .Parameters(8) = txtTrailerNo.value
    .Parameters(9) = txtUser.value
    .Parameters(10)= txtFLM.value
    .Parameters(11)= txtWhoAdded.value
    .Parameters(12)= txtDtAdded.Value
    .Execute
End With

 

[murray83]

With Currentdb.CreateQueryDefs("", "INSERT INTO tbl_Returns (Dt, Supplier, Reservation, " & _
                                    "PO, SKU, CaseCount, PalletCount, Reason, TrailerNumber, " & _
                                    "UserName, FLM, AddedBy, DtAdded) SELECT p0, p1, p2, p3, p4, " & _
                                    "p5, p6, p7, p8, p9, p10, p11, p12;")
    .Parameters(0) = txtDT.value
    .Parameters(1) = txtSupplier.value
    .Parameters(2) = txtRef.value
    .Parameters(3) = txtPO.value
    .Parameters(4) = txtSKU.value
    .Parameters(5) = txtCaseCount.value
    .Parameters(6) = txtPalletCount.value
    .Parameters(7) = txtReason.value
    .Parameters(8) = txtTrailerNo.value
    .Parameters(9) = txtUser.value
    .Parameters(10)= txtFLM.value
    .Parameters(11)= txtWhoAdded.value
    .Parameters(12)= txtDtAdded.Value
    .Execute
End With

Cheers, for that i tried that commented out my sql code and pasted yours in underneath

and then got this error see attached

do i need to do some diming and declare stuff

 

[arnelgp]

remove the "s":

...CreateQueryDef( ...

 

[murray83]

remove the "s":

...CreateQueryDef( ...

i doff my virtual cap to you kind soul, cheers

 

[arnelgp]

do this to all your append/update vba, instead of the usual of putting proper delimiter to your fields.