Better way of writing this code?

[Webskater]

Hello all

Further to an earlier post asking how to check if forms were open ...

I have a form EditCompanyForm which pops up to let people edit the details of a company. The form can be opened from one of three forms.

When the EditCompanyForm is closed I want to update the form that opened it.

So I have this rather ungainly bit of code.
_____________________________________________________________
Private Sub Form_Unload(Cancel As Integer)
Dim oAccessObject As AccessObject
Dim FormName As String
FormName = "CompaniesForm"
Set oAccessObject = CurrentProject.AllForms(FormName)
If oAccessObject.IsLoaded Then
Form_CompaniesForm.Requery
End If

Dim oAccessObject1 As AccessObject
Dim FormName1 As String
FormName1 = "CompaniesCallForm"
Set oAccessObject1 = CurrentProject.AllForms(FormName1)
If oAccessObject1.IsLoaded Then
Form_CompaniesCallForm.Requery
End If

Dim oAccessObject2 As AccessObject
Dim FormName2 As String
FormName2 = "CallListForm"
Set oAccessObject2 = CurrentProject.AllForms(FormName2)
If oAccessObject2.IsLoaded Then
Form_CallListForm.Requery
End If
End Sub
___________________________________________________

Do I need 3 separate AccessObjects?

Should I be using ... Set oAccessOjbect = nothing ... at the end?

Is there a more elegant way of doing this?

Thanks for any insights.

 

[cuttsy]

One way that you could do it is to update the details in the source forms.

i.e.

DoCmd.OpenForm "EditCompanyForm ", , , , , acDialog

'Place code to refresh the form details here

When you open a form in dialog view it does not run the code below the OpenForm command untill you close EditCompanyForm.

 

[boblarson]

The shortening/simplification would entail this:

1. create a public variable in a module (not a form module) like strFormName. Then, on each form's event that opens the EditCompanyForm form place this code:

strFormName = Me.Name

2. On the unload event of the EditCompanyForm form place:

Dim oAccessObject As AccessObject
Set oAccessObject = CurrentProject.AllForms(strFormName)
If oAccessObject.IsLoaded Then
Application.Forms(strFormName).Requery
End If

 

[Webskater]

The shortening/simplification would entail this:

1. create a public variable in a module (not a form module) like strFormName. Then, on each form's event that opens the EditCompanyForm form place this code:

strFormName = Me.Name

2. On the unload event of the EditCompanyForm form place:

Dim oAccessObject As AccessObject
Set oAccessObject = CurrentProject.AllForms(strFormName)
If oAccessObject.IsLoaded Then
Application.Forms(strFormName).Requery
End If

Thanks for that.