If Then Else problem

[davesmith202]

I have the following code that doesn't seem to work properly.

        If Forms!frmDefaults!Ad1Headline = "" Then
        MsgBox "1"
            Forms!frmDefaults!Ad1Headline = Me.Title
        ElseIf Forms!frmDefaults!Ad2Headline = "" Then
        MsgBox "2"
            Forms!frmDefaults!Ad2Headline = Me.Title
        End If

Field Ad1Headline has a value in it, but I don't get to see "2" popup. Is there something obvious I am missing?

Thanks,

Dave

 

[Kiwiman]

Howzit

"2" will only pop up if AD2Headline is an empty string. If it is Null or has a value, nothing happens.

 

[davesmith202]

I want to check if it is null or an empty string. What is the best way of doing this?

 

[Kiwiman]

try this - untested

If Forms!frmDefaults!Ad1Headline = "" or isnull(Forms!frmDefaults!Ad1Headline) Then
        MsgBox "1"
            Forms!frmDefaults!Ad1Headline = Me.Title
        ElseIf Forms!frmDefaults!Ad2Headline = "" or isnull(Forms!frmDefaults!Ad2Headline) Then
        MsgBox "2"
            Forms!frmDefaults!Ad2Headline = Me.Title
        End If

 

[davesmith202]

Worked a treat and well spotted about the null.

 

[Darth Vodka]

try this - untested

Forms!frmDefaults!Ad1Headline = "" or isnull(Forms!frmDefaults!Ad1Headline)

or indeed

nz(Forms!frmDefaults!Ad1Headline,"") = ""