Load code faster

A

alpapak

Registered User.
Local time
Today, 01:25
Joined
Apr 3, 2006
Messages
64
hi
i have a form with 12 checkbox and 1 combobox
i use the following code

Code: 
Option Compare Database
Private Sub Form_Current()
If Me.Image1 = -1 Then
        Me.Parent.Image1.Visible = True
        Me.Image1_text.FontBold = True
    Else
        Me.Parent.Image1.Visible = False
        Me.Image1_text.FontBold = False
End If
    
If Me.Image2 = -1 Then
        Me.Parent.Image2.Visible = True
        Me.Image2_text.FontBold = True
    Else
        Me.Parent.Image2.Visible = False
        Me.Image2_text.FontBold = False
End If
If Me.Image3 = -1 Then
        Me.Parent.Image3.Visible = True
        Me.Image3_text.FontBold = True
    Else
        Me.Parent.Image3.Visible = False
        Me.Image3_text.FontBold = False
End If
If Me.Image4 = -1 Then
        Me.Parent.Image4.Visible = True
        Me.Image4_text.FontBold = True
    Else
        Me.Parent.Image4.Visible = False
        Me.Image4_text.FontBold = False
End If
If Me.Image5 = -1 Then
        Me.Parent.Image5.Visible = True
        Me.Image5_text.FontBold = True
    Else
        Me.Parent.Image5.Visible = False
        Me.Image5_text.FontBold = False
End If
    
If Me.Image6 = -1 Then
        Me.Parent.Image6.Visible = True
        Me.Image6_text.FontBold = True
    Else
        Me.Parent.Image6.Visible = False
        Me.Image6_text.FontBold = False
End If
    
If Me.Image7 = -1 Then
        Me.Parent.Image7.Visible = True
        Me.Image7_text.FontBold = True
    Else
        Me.Parent.Image7.Visible = False
        Me.Image7_text.FontBold = False
End If
    
If Me.Image8 = -1 Then
        Me.Parent.Image8.Visible = True
        Me.Image8_text.FontBold = True
    Else
        Me.Parent.Image8.Visible = False
        Me.Image8_text.FontBold = False
End If
    
If Me.Image9 = -1 Then
        Me.Parent.Image9.Visible = True
        Me.Image9_text.FontBold = True
    Else
        Me.Parent.Image9.Visible = False
        Me.Image9_text.FontBold = False
End If
    
If Me.Image10 = -1 Then
        Me.Parent.Image10.Visible = True
        Me.Image10_text.FontBold = True
    Else
        Me.Parent.Image10.Visible = False
        Me.Image10_text.FontBold = False
End If
    
If Me.Image11 = -1 Then
        Me.Parent.Image11.Visible = True
        Me.Image11_text.FontBold = True
    Else
        Me.Parent.Image11.Visible = False
        Me.Image11_text.FontBold = False
End If
    
If Me.ComboBox1 = "No" Then
        Me.Parent.ComboBox1.Visible = False
        Me.ComboBox1_text.FontBold = False
    Else
        Me.Parent.ComboBox1.Visible = True
        Me.ComboBox1_text.FontBold = True
End If
    
If Me.Image12 = -1 Then
        Me.Parent.Image12.Visible = True
        Me.Image12_text.FontBold = True
    Else
        Me.Parent.Image12.Visible = False
        Me.Image12_text.FontBold = False
End If
End Sub
Private Sub Image1_AfterUpdate()
    If Me.Image1 = -1 Then
        Me.Parent.Image1.Visible = True
        Me.Image1_text.FontBold = True
    Else
        Me.Parent.Image1.Visible = False
        Me.Image1_text.FontBold = False
    End If
End Sub
Private Sub Image2_AfterUpdate()
    If Me.Image2 = -1 Then
        Me.Parent.Image2.Visible = True
        Me.Image2_text.FontBold = True
    Else
        Me.Parent.Image2.Visible = False
        Me.Image2_text.FontBold = False
    End If
End Sub
Private Sub Image3_AfterUpdate()
    If Me.Image3 = -1 Then
        Me.Parent.Image3.Visible = True
        Me.Image3_text.FontBold = True
    Else
        Me.Parent.Image3.Visible = False
        Me.Image3_text.FontBold = False
    End If
End Sub
Private Sub Image4_AfterUpdate()
    If Me.Image4 = -1 Then
        Me.Parent.Image4.Visible = True
        Me.Image4_text.FontBold = True
    Else
        Me.Parent.Image4.Visible = False
        Me.Image4_text.FontBold = False
    End If
End Sub
Private Sub Image5_AfterUpdate()
    If Me.Image5 = -1 Then
        Me.Parent.Image5.Visible = True
        Me.Image5_text.FontBold = True
    Else
        Me.Parent.Image5.Visible = False
        Me.Image5_text.FontBold = False
    End If
End Sub
Private Sub Image12_AfterUpdate()
    If Me.Image12 = -1 Then
        Me.Parent.Image12.Visible = True
        Me.Image12_text.FontBold = True
    Else
        Me.Parent.Image12.Visible = False
        Me.Image12_text.FontBold = False
    End If
End Sub
Private Sub Image6_AfterUpdate()
    If Me.Image6 = -1 Then
        Me.Parent.Image6.Visible = True
        Me.Image6_text.FontBold = True
    Else
        Me.Parent.Image6.Visible = False
        Me.Image6_text.FontBold = False
    End If
End Sub
Private Sub Image7_AfterUpdate()
    If Me.Image7 = -1 Then
        Me.Parent.Image7.Visible = True
        Me.Image7_text.FontBold = True
    Else
        Me.Parent.Image7.Visible = False
        Me.Image7_text.FontBold = False
    End If
End Sub
Private Sub ComboBox1_AfterUpdate()
    If Me.ComboBox1 = "No" Then
        Me.Parent.ComboBox1.Visible = False
        Me.ComboBox1_text.FontBold = False
    Else
        Me.Parent.ComboBox1.Visible = True
        Me.ComboBox1_text.FontBold = True
    End If
End Sub
Private Sub Image8_AfterUpdate()
    If Me.Image8 = -1 Then
        Me.Parent.Image8.Visible = True
        Me.Image8_text.FontBold = True
    Else
        Me.Parent.Image8.Visible = False
        Me.Image8_text.FontBold = False
    End If
End Sub
Private Sub Image9_AfterUpdate()
    If Me.Image9 = -1 Then
        Me.Parent.Image9.Visible = True
        Me.Image9_text.FontBold = True
    Else
        Me.Parent.Image9.Visible = False
        Me.Image9_text.FontBold = False
    End If
End Sub
Private Sub Image10_AfterUpdate()
    If Me.Image10 = -1 Then
        Me.Parent.Image10.Visible = True
        Me.Image10_text.FontBold = True
    Else
        Me.Parent.Image10.Visible = False
        Me.Image10_text.FontBold = False
    End If
End Sub
Private Sub Image11_AfterUpdate()
    If Me.Image11 = -1 Then
        Me.Parent.Image11.Visible = True
        Me.Image11_text.FontBold = True
    Else
        Me.Parent.Image11.Visible = False
        Me.Image11_text.FontBold = False
    End If
End Sub

how to optimize my code to run faster???

the images are 1 KB size , 16x16 pixels and .bmp
All of them are insert inside db.

i think images are too small to slow down my code.
Can i write the code in a different way?
 
Except for your combo box, this code does the same work as what you posted. Not sure it will run faster though...

Code: 
Function UpdateImage(iNum as string)
[COLOR="Green"]'Single stand alone function to update any image as determined by "iNum"[/COLOR]
  With Me.Parent.Controls("Image" & iNum)
[COLOR="Green"]    'set the visibility of the parent control equal to the value of the image control
[/COLOR]    .Visible = Me.Controls("Image" & iNum)
[COLOR="Green"]    'set the bold property equal to the visibility of the parent control[/COLOR]
    Me.Controls("Image" & iNum & "_text").FontBold = .Visible
  End With
End Function

Code: 
Private Sub Form_Current()
[COLOR="Green"]  'call UpdateImage for each image[/COLOR]
  Dim i as integer
  For i = 1 to 11
    UpdateImage CStr(i)
  Next i
End Sub

Then, in the property sheet->Events tab for each image control, delete "[Event Procedure]" from the AfterUpdate handler, and change it to =UpdateImage("1") for "Image1", =UpdateImage("2") for "Image2" and so on.
 
You must log in or register to reply here.

Similar threads

J
Error "Can't set focus"
2
Replies
21
Views
963
Isaac
Isaac
J
visible = true is false
2
Replies
23
Views
1,264
John Sh
J
J
me.visible = true is false
Replies
8
Views
532
The_Doc_Man
The_Doc_Man
saharalayer
Show a specific field
Replies
9
Views
746
Pat Hartman
P
W
Hiding text box in Report View
Replies
11
Views
509
DHookom
DHookom

Users who are viewing this thread

Total: 1 (members: 0, guests: 1)
Back
Top Bottom