Not Looping?

[GavZ]

hi,

i have a continuous form where i am trying to get a loop statement working, i have tried simplifying it so that if the checkbox in the record is checked the write checked! in the textbox but it still not working!

Can anybody tell me why this isnt looping through the records?


Dim Rs As DAO.Recordset
Set Rs = CurrentDb.OpenRecordset("tfiles")

If Not Rs.EOF And Not Rs.BOF Then

Do Until Rs.EOF
If chbox_rec = True Then
tb_test.Value = "Checked!"
Endif
Rs.MoveNext
Loop
Rs.Close
End If

Set Rs = Nothing

 

[Taruz]

Hi..:

Try this way..:


Dim Rs As Recordset
Set Rs = Form.Recordset

If Not Rs.EOF And Not Rs.BOF Then

Do Until Rs.EOF
If chbox_rec = True Then
tb_test = "Checked!"

End If
Rs.MoveNext
Loop

End If

 

[GavZ]

Perfect thanks! - So simple!

 

[vbaInet]

Dim Rs As Recordset

It's best to be explicit so revert back to

Dim Rs As DAO.Recordset

Also, why are you looping through a recordset when you can do it quicker and in one go using an UPDATE query or statement

 

[GavZ]

Because I was just testing the loop before I change it to call a separate function instead of just writing to a text box

 

[vbaInet]

In any case you can use call an UPDATE query to make the changes. Looping through a recordset is slower than doing it the SQL way.