Solved Print selected invoice (1 Viewer)

[Mercy Mercy]

Hello everyone. I have a slight problem. The following code does not fire to print selected records in invoice. It is supposed to filter the selected records and the studentID

Private Sub Command48_Click()
Dim sFilter As String
On Error Resume NextDoCmd.CLOSE acReport, "INVOICE"
sFilter = Me.SelectedList & ""If Len(sFilter) <> 0 Then    Do While Right$(sFilter, 1) = ","        sFilter = Left$(sFilter, Len(sFilter) - 1)    Loop    Do While Left$(sFilter, 1) = ","        sFilter = Mid$(sFilter, 2)    Loop    DoCmd.OpenReport "INVOICE", acViewPreview, , "StudentID IN (" & sFilter & ")"Else    DoCmd.OpenReport "INVOICE", acViewPreviewEnd IfEnd Sub

I have attached an image to show the selected records.
Thanks in advance

 

[Gasman]

Don't try and be clever.
Break it down to logical steps.

Then use Debug.Print to see what sFilter actually is, not what you think it is.

ALso try and give your controls meaningful names. Command48 is not going to mean much to anyone 6 months down the line.

 

[ebs17]

The following code does not fire

Of course, the code is also full of errors.
Throw out these mistakes or start over.

 

[Mercy Mercy]

Don't try and be clever.
Break it down to logical steps.

Then use Debug.Print to see what sFilter actually is, not what you think it is.

ALso try and give your controls meaningful names. Command48 is not going to mean much to anyone 6 months down the line.

Enthusiastic amateur I like your name but you have not assisted in anyway.

 

[Mercy Mercy]

Of course, the code is also full of errors.
Throw out these mistakes or start over.

Kindly assist me note those errors that is why I came to this forum for assistance

 

[Mercy Mercy]

Don't try and be clever.
Break it down to logical steps.

Then use Debug.Print to see what sFilter actually is, not what you think it is.

ALso try and give your controls meaningful names. Command48 is not going to mean much to anyone 6 months down the line.

I thought it is common sense Command48 is PRINT SELECTED INVOICE as the title and the image attached?????

 

[ebs17]

First Step:
On Error Resume Next|DoCmd.CLOSE acReport, "INVOICE"

That's TWO statements, so it should be TWO lines of code.
Change that, same stuff below just like that.
Then you present the changed code again.

Additionally: If you simply start a procedure with "On Error Resume Next", you want to ignore errors, not fix them. Something like that deserves a (symbolic) headbutt.

 

[arnelgp]

we dont know what is SelectedList but you may try:

Private Sub Command48_Click()
    Dim sFilter As String
    On Error Resume Next
    DoCmd.Close acReport, "INVOICE"
    On Error GoTo err_handler
    sFilter = Trim$(Me.SelectedList & "")
    If Right$(sFilter, 1) = "," Then
        sFilter = Left$(sFilter, Len(sFilter) - 1)
    End If
    If Left$(sFilter, 1) = "," Then
        sFilter = Mid$(sFilter, 2)
    End If
    If Len(sFilter) <> 0 Then
        DoCmd.OpenReport "INVOICE", acViewPreview, , "StudentID IN (" & sFilter & ")"
    Else
        DoCmd.OpenReport "INVOICE", acViewPreview
    End If
exit_sub:
    Exit Sub
err_handler:
    MsgBox Err.Number & ": " & Err.Description
    Resume exit_sub
End Sub

 

[Mercy Mercy]

we dont know what is SelectedList but you may try:

Private Sub Command48_Click()
    Dim sFilter As String
    On Error Resume Next
    DoCmd.Close acReport, "INVOICE"
    On Error GoTo err_handler
    sFilter = Trim$(Me.SelectedList & "")
    If Right$(sFilter, 1) = "," Then
        sFilter = Left$(sFilter, Len(sFilter) - 1)
    End If
    If Left$(sFilter, 1) = "," Then
        sFilter = Mid$(sFilter, 2)
    End If
    If Len(sFilter) <> 0 Then
        DoCmd.OpenReport "INVOICE", acViewPreview, , "StudentID IN (" & sFilter & ")"
    Else
        DoCmd.OpenReport "INVOICE", acViewPreview
    End If
exit_sub:
    Exit Sub
err_handler:
    MsgBox Err.Number & ": " & Err.Description
    Resume exit_sub
End Sub

Error 3075: Invalid use of vertical bars in query expression 'StudentID IN (11|)'.

 

[arnelgp]

your delimiter is vertical bar? try more:

Private Sub Command48_Click()
    Dim sFilter As String
    On Error Resume Next
    DoCmd.Close acReport, "INVOICE"
    On Error GoTo err_handler
    sFilter = Trim$(Replace$(Me.SelectedList & "", "|", ","))
    If Right$(sFilter, 1) = "," Then
        sFilter = Left$(sFilter, Len(sFilter) - 1)
    End If
    If Left$(sFilter, 1) = "," Then
        sFilter = Mid$(sFilter, 2)
    End If
    If Len(sFilter) <> 0 Then
        DoCmd.OpenReport "INVOICE", acViewPreview, , "StudentID IN (" & sFilter & ")"
    Else
        DoCmd.OpenReport "INVOICE", acViewPreview
    End If
exit_sub:
    Exit Sub
err_handler:
    MsgBox Err.Number & ": " & Err.Description
    Resume exit_sub
End Sub

 

[Mercy Mercy]

your delimiter is vertical bar? try more:

Private Sub Command48_Click()
    Dim sFilter As String
    On Error Resume Next
    DoCmd.Close acReport, "INVOICE"
    On Error GoTo err_handler
    sFilter = Trim$(Replace$(Me.SelectedList & "", "|", ","))
    If Right$(sFilter, 1) = "," Then
        sFilter = Left$(sFilter, Len(sFilter) - 1)
    End If
    If Left$(sFilter, 1) = "," Then
        sFilter = Mid$(sFilter, 2)
    End If
    If Len(sFilter) <> 0 Then
        DoCmd.OpenReport "INVOICE", acViewPreview, , "StudentID IN (" & sFilter & ")"
    Else
        DoCmd.OpenReport "INVOICE", acViewPreview
    End If
exit_sub:
    Exit Sub
err_handler:
    MsgBox Err.Number & ": " & Err.Description
    Resume exit_sub
End Sub

It provides print preview for a different student

 

[arnelgp]

then the filter you have is coming from wrong Table.
i don't see any student in your snapshot on #1.

 

[Mercy Mercy]

then the filter you have is coming from wrong Table.
i don't see any student in your snapshot on #1.

Thanks @arnelgp Your code works perfectly. The problem was PaymentID and not StudentID.
Thanks so much @arnelgp
God bless you so much.