Reveal subform when clicking cmd button

[ukmale65000]

I currently have a command button on my main form, and am trying to get a list of supplimentry questions to appear when i press the command button.
Currently the code i use is
Private Sub cmd_nds_Click()
Dim ctl As Control
For Each ctl In Me.Controls
If ctl.Tag = "showx" Then
ctl.Visible = Me.cmd_nds
End If
Next ctl
End Sub
This does not work with the line " ctl.Visible = Me.cmd_nds
" being highlighted any idea why?

Thanks in advance

 

[pbaldy]

A regular button has no value. If you want to toggle the visibility, use a toggle button instead of a regular button.

 

[ukmale65000]

Have changed to a toggle button, can you tell me what the code should now read for the on click function
I have tried
Private Sub Toggle88_Click()
Dim ctl As Control
For Each ctl In Me.Controls
If ctl.Tag = "showx" Then
ctl.Visible = Me.Toggle88
End If
End Sub
but it dosent work

 

[pbaldy]

Have you put "showx" in the tag property of the controls you want affected? That code looks okay to me. Can you post the db?

 

[ukmale65000]

Database too large to include even zipped . sorry

 

[ukmale65000]

i get the message Compile error For without next

 

[pbaldy]

Oh, I didn't notice you dropped the

Next ctl

that you had in the original code. You need to put it back.

 

[ukmale65000]

Ok have put that back now get an error message Next without For ??

This is the code i have in place
Private Sub Toggle88_Click()
Dim ctl As Control
For Each ctl In Me.Controls
If ctl.Tag = "showx" Then
ctl.Visible = Me.Toggle88
Next ctl
End If
End Sub
Im pulling whats left of my hair out can you help?

 

[pbaldy]

It needs to be after the End If line.

 

[ukmale65000]

Thanks that works great