Unable to correctly use a module for a file browser

[Nevy]

Hi, I want to use a module for creating a window file broswer, found here.

It is going to be use to insert an excel file in a table.

The problem is that when I click on cancel, it gives me an error since it doesn't have the string of the filename.

How can I correct that?

At first, this is what I did:

DoCmd.TransferSpreadsheet acImport, , "MainPrinterTable", GetOpenFile(), True

Then I added this, but still gives me an error.

Dim strFilePath As String
       
strFilePath = GetOpenFile()
    
If Not IsNull(strFilePath) Then
   DoCmd.TransferSpreadsheet acImport, , "MainPrinterTable", strFilePath, True
End If

The operation of actually importing the file works, it's just the cancel button that isn't.

 

[modest]

If strFilePath <> ""

IsNull() is looking for a Null

Becareful when looking for Null Variables or just Variables that have empty strings. There came a point when I was regularly checking for Nulls or Empty strings so I just made a different function:

Public Function IsNullOrEmpty(varValue As Variant) As Boolean
    IsNullOrEmpty = False
    If IsNull(varValue) Or varValue = "" Then
        IsNullOrEmpty = True
        Exit Function
    End If
End Function

 

[Nevy]

Thanks. It worked.

 

[RuralGuy]

I think this would also work:
If Len(varValue & "") = 0 then
'-- Nothing in there!

 

[modest]

Yes it would, but it would also mean that if the string was really long, it would have to get the length of the string, which requires more processing time

 

[ghudson]

If strFilePath <> ""

IsNull() is looking for a Null

Becareful when looking for Null Variables or just Variables that have empty strings. There came a point when I was regularly checking for Nulls or Empty strings so I just made a different function:

Public Function IsNullOrEmpty(varValue As Variant) As Boolean
    IsNullOrEmpty = False
    If IsNull(varValue) Or varValue = "" Then
        IsNullOrEmpty = True
        Exit Function
    End If
End Function

modest, I like that. Good idea!

nevy, Why reinvent the wheel? Searching this forum would have led you to this...
Browse [Find a directory or file]

 

[modest]

When you're really worried about the speed of the program, I wouldn't implement it, but for those times when you're sick of typing it over again and again.. I like to have it

 

[modest]

Instead of calling a seperate function I'm now using a new method.

Normally I would post this in the Code Repository, but I thought I should post it here since we've been discussing it in this post. It similar to RuralGuy's post, but it doesn't require calling another function, instead it just concatenates and evaluates the expression in the if statement:

 If varValue & "" = "" Then

This concatenates a "" to the varValue and then evaluates the expression. This is the most resource-efficient way I can think of for completing this. Thank you RuralGuy for your input.

 

[RuralGuy]

You're very welcome. It looks like you have struck on an excellent solution. I didn't realize this was not the OP when I responded the first time.