Run-time Error 91 variable not set (class Modules)

[VSolano]

Hi,
I am trying to better understand the class modules in Access vba. I created my first class and I am getting a variable not set error and I can not figure out what is the problem

Any guidance will be greatly appreciate.

' the class module has the following code'
Option Compare Database
Option Explicit

Private oForm As Form
Private ControlCollection As VBA.Collection

Public Property Set p_Form(vNewValue As Form)
   Set oForm = vNewValue
  
End Property
Public Property Get p_Form() As Form
   Set p_Form = oForm

End Property
'I am calling the code from a click bottom on the form'
Option Compare Database
Option Explicit
Private NewFrm As Cls_Form


Private Sub btnTest_Click() 
  

  Set NewFrm = New Cls_Form 
   Set NewFrm.p_Form = Me
  
End Sub

 

[theDBguy]

Which line is giving you the error?

 

[arnelgp]

I tested your code and it works fine without any error.

 

[VSolano]

I am still getting Run-time error 91
Object variable or with block variable not set

 

[theDBguy]

I am still getting Run-time error 91
Object variable or with block variable not set

On which line?

 

[VSolano]

the code works fine when I remove the information from the class initialize. The error is in here

Private Sub Class_Initialize()
  
   Dim Ctr As Control
  
   Set ControlCollection = New Collection
   For Each Ctr In oForm.Controls
      Select Case Ctr.ControlType
         Case acLabel
            Ctr.ForeColor = ColorBank.Blue
            
      End Select
   Next
   Set Ctr = Nothing 
  

End Sub

 

[June7]

"Variable not defined" on ColorBank.

Is there more code you have not provided? Could provide db for analysis.

I fix that then get your error on Set NewFrm = New Cls_Form

Your Class_Initialize doesn't make sense to me as it is not setting default values of class properties. It is setting formatting properties of controls. Seems to me that belongs in another procedure. And don't see a custom class is any benefit here. Exactly what are you trying to accomplish?

Why do you Set ControlCollection then don't use it?

 

[arnelgp]

Class_Initialize() is not the event to set up those colors on the Form.
Class_Initialized() will be called First when you instantiate the Class.
therefore, the Class don't know anything about oForm (or oForm is not yet Created).
create a New Private method/event to set the colors, and don't use Class_Initialize().
I am assuming you have Public Enum ColorBank somewhere on any Module.

example (Cls_Form class):

Private oForm As Form
Private ControlCollection As VBA.Collection

Public Property Set p_Form(vNewValue As Form)
   Set oForm = vNewValue
  
  ' Setup colors for the controls
  Call SetUpControlColors
  
End Property

Public Property Get p_Form() As Form
   Set p_Form = oForm

End Property


Private Sub SetUpControlColors()

  Dim Ctr As Control
  

   For Each Ctr In oForm.Controls
      Select Case Ctr.ControlType
         Case acLabel
            Ctr.ForeColor = ColorBank.Blue
            
      End Select
   Next
   Set Ctr = Nothing
  
End Sub

Private Sub Class_Initialize()
   Set ControlCollection = New Collection
End Sub

Private Sub Class_Terminate()
   Set ControlCollection = Nothing
End Sub

 

[VSolano]

Class_Initialize() is not the event to set up those colors on the Form.
Class_Initialized() will be called First when you instantiate the Class.
therefore, the Class don't know anything about oForm (or oForm is not yet Created).
create a New Private method/event to set the colors, and don't use Class_Initialize().
I am assuming you have Public Enum ColorBank somewhere on any Module.

example (Cls_Form class):

Private oForm As Form
Private ControlCollection As VBA.Collection

Public Property Set p_Form(vNewValue As Form)
   Set oForm = vNewValue
 
  ' Setup colors for the controls
  Call SetUpControlColors
 
End Property

Public Property Get p_Form() As Form
   Set p_Form = oForm

End Property


Private Sub SetUpControlColors()

  Dim Ctr As Control
 

   For Each Ctr In oForm.Controls
      Select Case Ctr.ControlType
         Case acLabel
            Ctr.ForeColor = ColorBank.Blue
           
      End Select
   Next
   Set Ctr = Nothing
 
End Sub

Private Sub Class_Initialize()
   Set ControlCollection = New Collection
End Sub

Private Sub Class_Terminate()
   Set ControlCollection = Nothing
End Sub

 

[VSolano]

Class_Initialize() is not the event to set up those colors on the Form.
Class_Initialized() will be called First when you instantiate the Class.
therefore, the Class don't know anything about oForm (or oForm is not yet Created).
create a New Private method/event to set the colors, and don't use Class_Initialize().
I am assuming you have Public Enum ColorBank somewhere on any Module.

example (Cls_Form class):

Private oForm As Form
Private ControlCollection As VBA.Collection

Public Property Set p_Form(vNewValue As Form)
   Set oForm = vNewValue
 
  ' Setup colors for the controls
  Call SetUpControlColors
 
End Property

Public Property Get p_Form() As Form
   Set p_Form = oForm

End Property


Private Sub SetUpControlColors()

  Dim Ctr As Control
 

   For Each Ctr In oForm.Controls
      Select Case Ctr.ControlType
         Case acLabel
            Ctr.ForeColor = ColorBank.Blue
           
      End Select
   Next
   Set Ctr = Nothing
 
End Sub

Private Sub Class_Initialize()
   Set ControlCollection = New Collection
End Sub

Private Sub Class_Terminate()
   Set ControlCollection = Nothing
End Sub

Thanks so much for your guidance.

It help to clear up my issues.