Calling Public Sub from an Array (1 Viewer)

[KevinBaker]

In a module I have:

Public FormArray(9) As String

Public Sub modContinue()
  If FormArray(0) <> "" Then
    Select Case left$(FormArray(0), 2)
      Case "fr": DoCmd.OpenForm FormArray(0)
      Case "cm": Call FormArray (0)
    End Select
    
    'Shift the remaining elements up one
    For i = 1 To UBound(FormArray)
      FormArray(i - 1) = FormArray(i)
    Next
  Else
    If Not IsNull(TempVars!frmReport) Then
      Forms(TempVars!frmReport).Visible = True
    End If

    'Open the report
    On Error Resume Next
    DoCmd.OpenReport TempVars!txtRptName, View:=acViewPreview
            
    If Err = 2501 Then
      Err.Clear
      Exit Sub
    End If
    DoCmd.Maximize
  End If
End Sub

On a FormA if I have a Public Sub called cmHelloWorld like this:

Public Sub cmHelloWorld()
  MsgBox "Hello World"
End Sub

Using a button on the form I run this code:

FormArray(0) = "frmTest2"
FormArray(1) = "cmHelloWorld"
Call modContinue

When I press the button frmTest2 opens correctly, however when I click the Continue button on frmTest2, which calls modContinue, trying to run cmHelloWorld fails with "Expected procedure, not variable

 

[Gasman]

Walk though your code line by line with F8.
You shift the array values up one, but how do you test it again?

Why is there a space between FormArray and (0) for cm ? and not elsewhere?

 

[arnelgp]

when the Form is not open, how can the Sub be accessed?
also using Call is not the appropriate action.
try googling CallByName.

 

[KevinBaker]

Gasman - it's test each time the "Continue" button is clicked, which just runs modContinue again

arnelgp - CallByName did the trick! Thanks!

 

[Gasman]

@arnelgp
Would Eval() work for this as well?

 

[Pat Hartman]

Put your common code in a standard code module. It does not belong in a form's class module. The only time I would put a shared module in a form's class module is if the procedure is only called from the form.

Good organization is good practice.

 

[KevinBaker]