Solved Code Error (1 Viewer)

[Niroshana]

Hi

The following SUB is not working. Hence please help me to correct the Code.


Public Sub USERACTV(Frm As Form, ANum As Integer)

If ANum = 1 Then

Forms(Frm.Name).Controls(btnNew).Enable = True

Else

Forms(Frm.Name).Controls(btnNew).Enable = False

End If

End Sub

 

[Gasman]

Walk through the code with F8 after setting a breakpoint on the If statement.

Where is variable btnNew declared/populated?

 

[Gasman]

This would work

Public Sub USERACTV(Frm As Form, ANum As Integer)
    If ANum = 1 Then
        Forms(Frm.Name).Controls("btnNew").Enabled = True
    Else
        Forms(Frm.Name).Controls("btnNew").Enabled = False
    End If

End Sub

however as you are passing the form in I'd probably use

Public Sub USERACTV(Frm As Form, ANum As Integer)

    If ANum = 1 Then
        Frm.btnNew.Enabled = True
    Else
        Frm.btnNew.Enabled = False
    End If

End Sub

 

[Micron]

I think all references passed when using .Controls( ) syntax require double quotes?
Forms("FrmName").Controls("btnNew").Enable = True

 

[Gasman]

Sorry, I should have said 'Does work' as I tested it on one of my forms.
That was when I spotted you had 'enable' and not 'enabled'

 

[arnelgp]

you may also try:

Public Sub USERACTV(Byref Frm As Form, ByVal btnNew As String, Byval ANum As Integer)
    Frm.Controls(btnNew).Enabled = (ANum = 1)
End Sub

you then call the Sub:

USEERACTV Me, "theCommandButtonNameHere", 1

 

[Galaxiom]

I think all references passed when using .Controls( ) syntax require double quotes?
Forms("FrmName").Controls("btnNew").Enable = True

You missed the dot in frm.Name

Double quotes are literal string delimiters. A string variable or reference to a string property such as frm.Name inside the parenthesis is the same as putting a literal string there.

btnNew is a literal string so would need delimiters.

 

[cheekybuddha]

Least code solution:

Public Sub USERACTV(Frm As Form, ANum As Integer)

   Frm.btnNew.Enabled = ANum = 1

End Sub

 

[Micron]

You missed the dot in frm.Name

Actually, I omitted it, not missed it, because I overlooked the fact that frm was a variable and I was thinking along the lines of Me.Controls("frmName") where frnName is just a pseudonym for the name of the form (like "FormNameHere"). So yeah, dumb of me.

 

[Niroshana]

Thank you Very much for your valuable replies!