If statement not working

[Workaholic]

Private Sub cmdFeedSub_Click()

If IsNull(txtfirstname) Or IsNull(txtsecondname) Or IsNull(txtteam) Or IsNull(txtRegion) Or IsNull(txtsupport_id) Then
Me.lblRed1.Visible = True
Cancel = True

Else
Me.lblGreen.Visible = True
DoCmd.RunCommand acCmdSaveRecord

End If

Can anyone tell me why this statement won't go by the first part.

Cheers

 

[Mile-O]

What error message are you receiving?

 

[KenHigg]

If IsNull(me!txtfirstname)


???
ken

 

[Workaholic]

No matter if the conditions are met or not it still only executes the first part.

 

[Workaholic]

So there is no error message but the criteria fails to work. I can't see why this is the case

 

[maxmangion]

are you sure that the fieldnames are all spelled correctly ?

 

[Rich]

There aren't enough brackets around all the Or conditions, it's much easier to have them as separate statements.

I didn't think Cancel=True was available for command buttons either?

 

[KenHigg]

Rich - Did I miss something obvious with:

If IsNull(me!txtfirstname)...

???
ken

 

[Rich]

No, although I prefer the dot to the bang I think the statement should look more like

If ( IsNull(txtfirstname) Or IsNull(txtsecondname) Or IsNull(txtteam) Or IsNull(txtRegion) Or IsNull(txtsupport_id)) Then

 

[KenHigg]

No, although I prefer the dot to the bang I think the statement should look more like

If ( IsNull(txtfirstname) Or IsNull(txtsecondname) Or IsNull(txtteam) Or IsNull(txtRegion) Or IsNull(txtsupport_id)) Then

But where is the me. in IsNull(txtfirstname)? Do you not need it?

ken

 

[Mile-O]

Remove Cancel = True - it shouldn't, as Rich says, be there.

You can replace it with Me.Undo