MsgBox if yes then... need a hint! (1 Viewer)

[vidus]

Alright, still in the learning curve here, I need a hint to finish this code up. Its not changing the fields as I want it to when ok is clicked... what did I miss?

Private Sub Command57_Click()
  
On Error GoTo errorHandler

MsgBox "This job will be deactivated from the Job Board, are you sure?", vbYesNo, "Ok?"

    If Answer = vbYes Then
     Me.[Active] = False
     Me.[Invoiced] = True
    End If

    If Answer = vbNo Then
      GoTo ExitHandler
    End If


ExitHandler:
  Exit Sub
errorHandler:
  MsgBox Err.Description

End Sub

 

[pbaldy]

You're never setting your variable to the result of the message box:

Dim Answer As Integer
Answer = MsgBox(...)

By the way, your second If/Then block is not necessary. Code execution would go to the exit handler anyway. If there was more code, I'd handle it with an Else in the first If/Then block.

 

[vidus]

You're never setting your variable to the result of the message box:

Dim Answer As Integer
Answer = MsgBox(...)

By the way, your second If/Then block is not necessary. Code execution would go to the exit handler anyway. If there was more code, I'd handle it with an Else in the first If/Then block.

Could you break down the Dim Answer as Integer? What does this mean or do?

Also, it doesnt seem to like the Answer = line, syntax error.

On Error GoTo errorHandler

Dim Answer As Integer
Answer = MsgBox "This job will be deactivated from the Job Board, are you sure?", vbYesNo, "Ok?"

    If Answer = vbYes Then
     Me.[Active] = False
     Me.[Invoiced] = True
    End If

    If Answer = vbNo Then
      GoTo ExitHandler
    End If


ExitHandler:
  Exit Sub
errorHandler:
  MsgBox Err.Description

 

[pbaldy]

Any time you're going to use a variable (which "Answer" is in your context), you should declare it. If you look up "Dim" in VBA help you'll get more info. Most of us put any declarations at the beginning of the sub. Most of us also recommend having Option Explicit at the top of every module, which forces you to declare your variables. More info on that in VBA help as well.

When you're capturing the result, you need the parentheses that I included in my example.

 

[vidus]

Any time you're going to use a variable (which "Answer" is in your context), you should declare it. If you look up "Dim" in VBA help you'll get more info. Most of us put any declarations at the beginning of the sub. Most of us also recommend having Option Explicit at the top of every module, which forces you to declare your variables. More info on that in VBA help as well.

When you're capturing the result, you need the parentheses that I included in my example.

Thanks. I think a good book on VBA is in my near future.

 

[ghudson]

This is a cleaner way to do what you want...

Private Sub btnDeactivateJob_Click()
On Error GoTo Err_btnDeactivateJob_Click

     If MsgBox("Do you want to deactivate this job from the Job Board?", vbQuestion + vbYesNo, "Deactivea Job") = vbYes Then
          Me.[Active] = False
          Me.[Invoiced] = True
     Else
          Exit Sub
     End If

Exit_btnDeactivateJob_Click:
    Exit Sub

Err_btnDeactivateJob_Click:
    MsgBox Err.Number & " - " & Err.Description, vbCritical, "btnDeactivateJob_Click()"
    Resume Exit_btnDeactivateJob_Click
    
End Sub