Problem about field update using function with case.

[abzalali]

Dear Experts,
I'm trying to update some field value depending two string field using a function with if and case, function below:

Private Function checkDATI(tipotransazione As String, tipovendita As String) As String

Dim r As String
r = ""
If tipotransazione = "VENDITA" Then
    Select Case tipovendita
        Case "ARMI"
            If Me.txtMatricola = "" Then r = "Matricola"
            If Me.txtModello = "" Then r = "Modello"
            If Me.txtCalibro = "" Then r = "Calibro"
            If Me.txtTipoArma = "" Then r = "Tipo Arma"
            If Me.txtFabrica = "" Then r = "Fabbrica"
        Case "VENDITA ARMI/MUNIZIONI"
        Case "MUNIZIONI"
    End Select
End If

If tipotransazione = "ACQUISTO" Then
    Select Case tipovendita
        Case "ARMI"
            If Me.txtMatricola = "" Then r = "Matricola"
            If Me.txtModello = "" Then r = "Modello"
            If Me.txtCalibro = "" Then r = "Calibro"
            If Me.txtTipoArma = "" Then r = "Tipo Arma"
            If Me.txtFabrica = "" Then r = "Fabbrica"
        Case "VENDITA ARMI/MUNIZIONI"
        Case "MUNIZIONI"
    End Select
End If

checkDATI = r

End Function

And then when I call this function in a command button event as:

MsgBox (checkDATI(Me.CausaleMov, Me.txt_tipomov))

It's not update those field. Please anybody help me.

 

[MarkK]

To make the function return a value, you need to do an assignment, like . . .

Function checkDATI(s1, s2) As String
   dim r as string
   ...
[COLOR="Green"]   'code that assigns value to r[/COLOR]
   ...
   checkDATI = r  [COLOR="Green"]'assign value to function[/COLOR]
End Function

 

[sxschech]

seems like you are using the same value for all the if statements such that if all are true, it is going to return the last item in the list of if statements that meet the criteria, is that the intent?

 

[abzalali]

Dear sxschech,
I need to put it an array and update all field that are mentions in if statements. How could I do this?

Thanks

 

[sxschech]

do you have some more information about what the process is supposed to do? Is it taking data from two places on a form and then populating text boxes if those text boxes are = ""?

 

[MarkK]

Also, this code fails . . .

MsgBox (checkDATI(Me.CausaleMov, Me.txt_tipomov))

. . . because you never assign a value to your function . . .

Private Function checkDATI(tipotransazione As String, tipovendita As String) As String
Dim r As String
If tipotransazione = "VENDITA" Then
    Select Case tipovendita
        Case "ARMI"
            If Me.txtMatricola = "" Then r = "Matricola"
            If Me.txtModello = "" Then r = "Modello"
            If Me.txtCalibro = "" Then r = "Calibro"
            If Me.txtTipoArma = "" Then r = "Tipo Arma"
        Case "VENDITA ARMI/MUNIZIONI"
        Case "MUNIZIONI"
    End Select
End If

If tipotransazione = "ACQUISTO" Then
    Select Case tipovendita
        Case "ARMI"
            If Me.txtMatricola = "" Then r = "Matricola"
            If Me.txtModello = "" Then r = "Modello"
            If Me.txtCalibro = "" Then r = "Calibro"
            If Me.txtTipoArma = "" Then r = "Tipo Arma"
        Case "VENDITA ARMI/MUNIZIONI"
        Case "MUNIZIONI"
    End Select

[B][COLOR="Red"]    checkDATI = ???[/COLOR][/B]
End If

 

[vbaInet]

Maybe this is what abzalali is after

If tipotransazione = "VENDITA" Then
    Select Case tipovendita
        Case "ARMI"
            If Me.txtMatricola = "" Then 
                Me.txtMatricola = "Matricola"
            End If
            If Me.txtModello = "" Then
                Me.txtMatricola = "Modello"
            Enf If
            ... etc ...
        Case "VENDITA ARMI/MUNIZIONI"
        Case "MUNIZIONI"
    End Select
End If