Refer to X String from another public function or form

[gstylianou]

I have a Public Function like the example below. X is a String inside the function and takes value from a field in a form. The question is how can I refer to String X through another function or through a another form? I want to use another function to refer to the result of X in SetValuesFromForm, can something like this be done?

Public Function SetValuesFromForm()
Dim X As String

X= Forms!Form1.TextField1

End Function

 

[Gasman]

Make it Global or a TempVar

 

[gstylianou]

Make it Global or a TempVar

Make it Global or a TempVar
How can i do it Global? Its about 30 fields..so i thing TempVar for each maybe its not good idea

 

[MajP]

if that form is open then

Public Function GetValueFromForm() as variant
  getValueFromForm= Forms!Form1.TextField1
End Function

if you are setting a value and then closing the form I would use the Tempvars as already said

Access – TempVars | DEVelopers HUT

Everything you've ever wanted to know about Access TempVars (Temporary Variables). How to create, retrieve and delete TempVars in either VBA or through Macros.

www.devhut.net

 

[Gasman]

Make it Global or a TempVar
How can i do it Global? Its about 30 fields..so i thing TempVar for each maybe its not good idea

One minute it is one variable x, now it is 30???
Write them all to a temp table then?
Put them all into a hidden form and refer to that?

 

[MajP]

Its about 30 fields..so i thing TempVar for each maybe its not good idea

Can you explain why you are saving 30 Fields? There is probably a way smarter approach. Use Access as it was designed. Do not try reinventing the wheel. A beginner who does not know what Tempvars are or a global variable does not need to be writing code to save 30 variables.

 

[gstylianou]

Can you explain why you are saving 30 Fields? There is probably a way smarter approach. Use Access as it was designed. Do not try reinventing the wheel. A beginner who does not know what Tempvars are or a global variable does not need to be writing code to save 30 variables.

because i'm getting values bu running external service from Postgres

 

[arnelgp]

i thing TempVar for each maybe its not good idea

use Public Array(1 to 30) and populate each element from your form.

 

[MajP]

Still no idea how
' i'm getting values bu running external service from Postgres"
and this
"I want to use another function to refer to the result of X in SetValuesFromForm, can something like this be done?"
are in any way remotetly related. If 30 values have an associated name then may want to use a Dictionary object. TempVars would still work since it is a collection with an indexed name. What is the issue with using tempVars? But is not storing a name and a value then the array would be fast and efficient.

 

[Pat Hartman]

i'm getting values bu running external service from Postgres"

Can't you just link to the table? Then you don't need any code.

 

[Galaxiom]

Referring to anything outside a Public function other than by passing it through the function parameters is very, very poor design. Using Public variables or TempVars is just plain wrong. (Don't bother arguing.)

Encapsulation is a fundamental programming that would be breached by such suggestions.

Encapsulation (computer programming) - Wikipedia

en.wikipedia.org

If the function needs to refer to 30 members of a form then it should probably be a Method of that form.

If it needs to refer to multiple forms then the form objects should be passed as parameters so their members can be referred to from inside the function. However it sounds to me like the whole structural concept is likely to be flawed.

 

[gstylianou]

As I suspected, I probably haven't made it clear what the problem is

From an external server in the company, I receive data as a string from a Postgres table. I get this data through a service (java scripts) and it is in real time. I call the service through a module (ReadServerData) and I get all the data as a string. I read this data from a form (Login) if I call ReadServerData (public function).

What I am asking is how can I selectively read some of the string data which is inside the ReadServerData Function. For example, I want to refer to only one of them in the login form, let's say the Serial No of the application, which is SerialNo (Dim SerialNo As String into public function)

That's all.

 

[ebs17]

I receive data as a string

You mean you have to split the string into individual pieces of information? That would then be simple string processing with methods like
- Left/Right/Mid/Instr/Len
- Split
- regular expressions

 

[gstylianou]

You mean you have to split the string into individual pieces of information? That would then be simple string processing with methods like
- Left/Right/Mid/Instr/Len
- Split
- regular expressions

Already are split...! I just want to refer to just one String of them from another form, routine or function...! How?

 

[ebs17]

How are they there, these substrings?

The belief that others are constantly looking over your shoulder is widespread, but it is less based on facts than you might think.

 

[CJ_London]

you say the data is already split - split how? separate rows? into an array of some kind? and split with a field description and value? just a value?

Why can't you provide an example (doesn't have to be real data, just representative) of what you are looking at?

 

[Cotswold]

Am I missing something here? From #1 I would have the solution as :

Public Function SetValuesFromForm() as String
    Dim X As String

    X= Forms!Form1.TextField1
    SetVaulesFromForm= X

End Function ' SetValuesFromForm()

Then on any form or another Function add the lines

Dim Y as string
Y = SetvaluesfromForm()

Is that not the solution to #1??

If the function is in a module, I have never found the need to prefix them Private or Public. I just use Function().
Also, it is good practice to set the type of variable for all variables passed to and from a Function.

 

[CJ_London]

my guess would be

Function SetValuesFromForm(fname as string) as String

   SetValuesFromForm= Forms!Form1(fname)

End Function

 

[gstylianou]

Am I missing something here? From #1 I would have the solution as :

Public Function SetValuesFromForm() as String
    Dim X As String

    X= Forms!Form1.TextField1
    SetVaulesFromForm= X

End Function ' SetValuesFromForm()

Then on any form or another Function add the lines

Dim Y as string
Y = SetvaluesfromForm()

Is that not the solution to #1??

If the function is in a module, I have never found the need to prefix them Private or Public. I just use Function().
Also, it is good practice to set the type of variable for all variables passed to and from a Function.

wHERE YOU WAS ALL THIS TIME?? )
THANKS A LOT

 

[Galaxiom]

If the function is in a module, I have never found the need to prefix them Private or Public. I just use Function().
Also, it is good practice to set the type of variable for all variables passed to and from a Function.

A Function in a Standard Module is Public by default. If they don't need to be called from outside the module (ie only called by other Subs or Functions in the module) then they should be declared Private, hiding them from the rest of the project.

Functions in Class or Object Modules are Private by default. They become Methods of the Object or Class when declared Public.

Types of the parameters and return should be declared or they will be unnecessarily complex Variants by default.

Parameters should also be declared as ByVal or ByRef. ByVal means the value of the argument is passed. ByRef means a reference to the argument is passed. Changes to the value of the parameter inside the function or sub will be reflected back to the argument that has been passed. This is one way a function or sub can return multiple values.

Without the declaration, the parameters are ByRef by default. Arrays are always ByRef even if declared ByVal. The mismatch is ignored by the compiler.

Putting parentheses around an argument for a ByRef parameter in the call will cause it to be passed as a value instead.