Using modules in my Private Sub Function

[ariel81]

Hi,

I have a Public Sub in my modules:

 Public Sub CalcAge(vDate1 As Date, vdate2 As Date, ByRef vYears As Integer, ByRef vMonths As Integer, ByRef vDays As Integer)

In my form upon cmd button "OK" is clicked, it will use the Public Sub CalcAge function:

Private Sub cmdOK_Click()

    Dim bday As Date
    Dim input_date As Date
    Dim yrs As Integer
    Dim mths As Integer
    Dim days As Integer


         bday = Me.Text16
         input_date = Me.Text18

         Me.Text20 = CalcAge(bday, input_date, yrs, mths, days)
   
End Sub

- dates in Text16 and Text18 will be input into CalcAge and Text20 will display the "yrs, mths, days" from CalcAge

- however i will get an error msg at the statement :

Me.Text20 = CalcAge(bday, input_date, yrs, mths, days)

- did i wrote correctly for the abv statement?

 

[pbaldy]

I see 3 things wrong off the top. In order to return a value, you have to have a function rather than a sub. You haven't specified what it will return. You've declared yrs, mths and days but haven't given them any values, so you're sending Nulls to the function.

 

[ariel81]

how shall i correct it?

 

[Bat17]

just guessing as you dont show the function, but

Public Function CalcAge(vDate1 As Date, vdate2 As Date, ByRef vYears As Integer, ByRef vMonths As Integer, ByRef vDays As Integer)

Private Sub cmdOK_Click()
    Dim bd
    Dim bday As Date
    Dim input_date As Date
    Dim yrs As Integer
    Dim mths As Integer
    Dim days As Integer


         bday = Me.Text16
         input_date = Me.Text18

         bd = CalcAge(bday, input_date, yrs, mths, days)
         Me.Text20 = yrs & " Years, " & mths & " Months and " & days & " Days."
   
End Sub

you should really add some error trapping though to make sure that the dates have been filled in before calling the function. Also try to name your fields usefully.

HTH

Peter