Solved Code wont run correctly unless stepping through with breakpoints?

Sam Summers

Sam Summers

Registered User.
Local time
Today, 00:07
Joined
Sep 17, 2001
Messages
939
Hi Guys,

This code works as long as i set breakpoints and step through it but if i just open the form and try it does not initialise variable 'a'

I must be missing something because it works perfectly otherwise?

Many thanks in advance.

Code: 
Private Sub Form_Load()

Dim a As Integer
Dim b As Integer
Dim c As Integer
Dim d As Integer
Dim e As Integer
Dim f As Integer
Dim g As Integer
Dim answer As Integer
Dim answer2 As Integer
Dim answer3 As Integer
Dim answer4 As Integer
Dim answer5 As Integer
Dim MyVar, MyVar2, MyCheck

    MyVar = Me.TotalHours.Value
    MyVar2 = Me.ServiceInterval.Value

    If MyCheck = IsNull(MyVar) Or MyVar = "" Then

    Else
    End If
    
    a = Me.TotalHours.Value
    b = Me.ServiceInterval.Value
    d = Me.Component_FlagInterval.Value
    f = Me.WarningAt.Value
    If IsNull(MyVar2) Or MyVar2 = "" Then
    Exit Sub
    Else
    If Me.TotalHours.Value < MyVar2 Then
    answer2 = b - Me.TotalHours.Value
 '   answer2 = b - a
    Me.DueIn.Value = answer2
    Else
    answer = a / b
    Me.Divider.Value = answer
    e = Me.ServiceHour.Value
    f = Me.WarningAt.Value
    g = Me.WarningHour.Value
    
    If a > e Then
    answer3 = b + e
    answer4 = answer3 - a
    Me.DueIn.Value = answer4
    Else
    
 End If
End If
End If

End Sub
 
For a start, the if checks make no sense to me.

This does nothing
Code: 
 If MyCheck = IsNull(MyVar) Or MyVar = "" Then
    Else
    End If

and this is in the wrong place and no exit sub is needed
Code: 
 If IsNull(MyVar2) Or MyVar2 = "" Then
    Exit Sub
    Else
 
Also your variables make no sense. You have two variables for Me.TotalHours.Value, and still do not use either of them

a = Me.TotalHours.Value
MyVar = Me.TotalHours.Value
If Me.TotalHours.Value < MyVar2 Then

The whole thing is kind of a mess. I would probably start over and write something that is clear an understandable.
 
MajP said:
Also your variables make no sense. You have two variables for Me.TotalHours.Value, and still do not use either of them

a = Me.TotalHours.Value
MyVar = Me.TotalHours.Value
If Me.TotalHours.Value < MyVar2 Then

The whole thing is kind of a mess. I would probably start over and write something that is clear an understandable.
Click to expand...
Well if i knew how to do that i would?
Its taken me over a week to get my head round what i have now and as i said it works perfectly when i step through it but not otherwise and i dont understand why?
 
You also need to indent your code, otherwise it is harder to debug?

Code: 
Private Sub Form_Load()

    Dim a As Integer
    Dim b As Integer
    Dim c As Integer
    Dim d As Integer
    Dim e As Integer
    Dim f As Integer
    Dim g As Integer
    Dim answer As Integer
    Dim answer2 As Integer
    Dim answer3 As Integer
    Dim answer4 As Integer
    Dim answer5 As Integer
    Dim MyVar, MyVar2, MyCheck

    MyVar = Me.TotalHours.Value
    MyVar2 = Me.ServiceInterval.Value

    If MyCheck = IsNull(MyVar) Or MyVar = "" Then

    Else
    End If

    a = Me.TotalHours.Value
    b = Me.ServiceInterval.Value
    d = Me.Component_FlagInterval.Value
    f = Me.WarningAt.Value
    If IsNull(MyVar2) Or MyVar2 = "" Then
        Exit Sub
    Else
        If Me.TotalHours.Value < MyVar2 Then
            answer2 = b - Me.TotalHours.Value
            '   answer2 = b - a
            Me.DueIn.Value = answer2
        Else
            answer = a / b
            Me.Divider.Value = answer
            e = Me.ServiceHour.Value
            f = Me.WarningAt.Value
            g = Me.WarningHour.Value

            If a > e Then
                answer3 = b + e
                answer4 = answer3 - a
                Me.DueIn.Value = answer4
            Else

            End If
        End If
    End If

End Sub

Dim MyVar, MyVar2, MyCheck
These will be variants?
 
I have actually seen something like what you are describing where single-stepping or breakpointing works but a straight-out run doesn't. Treat the DB as having been corrupted somehow.

First, decompile your code, then compact and repair your DB and then compile your code. (NOTE: In the referenced article below, which is a gathering of several tips, "decompile" is not the first entry. Scroll down a bit an you'll see it.) Always, always, ALWAYS make a backup copy before you start work like this since it involves multiple places where things could go wrong.

Decompile and Compact Your Microsoft Access Database to Improve Performance and Fix Corruption

Decompile and Compact Your Microsoft Access Database to Improve Performance and Fix Corruption
www.fmsinc.com

If that doesn't work, create a brand new empty database and then use the External Data option to import everything from the old file to the new one. DO NOT try to EXPORT from old to new. Do it as an import from the old file.
 
Hi. Just curious, you said the problem was "it does not initialise variable 'a'," is that all? All the other variables get initialised?
 
I think it is something like this, from what I can see.
Code: 
Private Sub Form_Load()

if not (me.totalhours & "") = "" and Not (me.ServiceInterval & "") = "" then
    if me.TotalHours < me.ServiceInterval then
      me.dueinvalue = me.ServiceInterval - me.TotalHours
   else
      me.divider = me.TotalHours / me.ServiceInterval  
      if me.TotalHours > Me.ServiceHour then
         me.dueInValue = me.ServiceInterval + Me.ServiceHour - me.TotalHours
      end if
   end if
end if
end sub
 
Amazing guys! Let me just check it all works and i will get straight back to you!
 
However, I think this can be shortened more, if I understand correctly

All equipment has a service interval, a last service (servicehour), and total hours
If it has never been serviced would the servicehour be null or zero?
If that is the case then this is even simpler. Also would the divider always be calculated regardless if it exceeded the service interval.

Code: 
Private Sub Form_Load()


if not (me.totalhours & "") = "" and Not (me.ServiceInterval & "") = "" then
      me.divider = me.TotalHours / me.ServiceInterval 
      me.dueInValue = me.ServiceInterval + nz(Me.ServiceHour,0) - me.TotalHours
end if
end sub

if the
TotalHours = 75
ServiceInterval = 100
ServiceHours = Null or 0

Then Due in is: 100 + 0 - 75 = 25

if
TotalHours = 125
ServiceInterval = 100
ServiceHours = 100
Then Due in is: 100 + 100 - 125 = 75
 
Right at the moment using MajP's earlier code i am getting a "Type mismatch" error on line 60

Code: 
10 If Not (Me.TotalHours & "") = "" And Not (Me.ServiceInterval & "") = "" Then
20   If Me.TotalHours < Me.ServiceInterval Then
30      Me.DueIn.Value = Me.ServiceInterval - Me.TotalHours
40   Else
50      Me.Divider = Me.TotalHours / Me.ServiceInterval
60      If Me.TotalHours > Me.ServiceHour Then
70       Me.DueIn.Value = Me.ServiceInterval + Me.ServiceHour - Me.TotalHours
80      End If
90   End If
100 End If
 
MajP said:
However, I think this can be shortened more, if I understand correctly

All equipment has a service interval, a last service (servicehour), and total hours
If it has never been serviced would the servicehour be null or zero?
If that is the case then this is even simpler. Also would the divider always be calculated regardless if it exceeded the service interval.

Code: 
Private Sub Form_Load()


if not (me.totalhours & "") = "" and Not (me.ServiceInterval & "") = "" then
      me.divider = me.TotalHours / me.ServiceInterval
      me.dueInValue = me.ServiceInterval + nz(Me.ServiceHour,0) - me.TotalHours
end if
end sub

if the
TotalHours = 75
ServiceInterval = 100
ServiceHours = Null or 0

Then Due in is: 100 + 0 - 75 = 25

if
TotalHours = 125
ServiceInterval = 100
ServiceHours = 100
Then Due in is: 100 + 100 - 125 = 75
Click to expand...
I'll try this just now
 
That would hint to me that Service hour is not a numeric. You will need to check that, because
100 > "SomeString"
will return a type mismatch.
 
MajP said:
However, I think this can be shortened more, if I understand correctly

All equipment has a service interval, a last service (servicehour), and total hours
If it has never been serviced would the servicehour be null or zero?
If that is the case then this is even simpler. Also would the divider always be calculated regardless if it exceeded the service interval.

Code: 
Private Sub Form_Load()


if not (me.totalhours & "") = "" and Not (me.ServiceInterval & "") = "" then
      me.divider = me.TotalHours / me.ServiceInterval
      me.dueInValue = me.ServiceInterval + nz(Me.ServiceHour,0) - me.TotalHours
end if
end sub

if the
TotalHours = 75
ServiceInterval = 100
ServiceHours = Null or 0

Then Due in is: 100 + 0 - 75 = 25

if
TotalHours = 125
ServiceInterval = 100
ServiceHours = 100
Then Due in is: 100 + 100 - 125 = 75
Click to expand...
Yes it just threw an error again at nz(Me.ServiceHour,0)
 
You have that field likely bound to a text field. Look in the table and change to numeric.
 
theDBguy said:
Hi. Just curious, you said the problem was "it does not initialise variable 'a'," is that all? All the other variables get initialised?
Click to expand...
Yes all the others seem to work but i may have found the mismatch
 
So after finding the mismatch, this is working best now but still only stepping through breakpoints?

I think i have to do what Doc Man said and get back to you. Fantastic help everyone!!

Code: 
10 If Not (Me.TotalHours & "") = "" And Not (Me.ServiceInterval & "") = "" Then
20   If Me.TotalHours < Me.ServiceInterval Then
30      Me.DueIn.Value = Me.ServiceInterval - Me.TotalHours
40   Else
50      Me.Divider = Me.TotalHours / Me.ServiceInterval
60      If Me.TotalHours > Me.ServiceHour Then
70       Me.DueIn.Value = Me.ServiceInterval + Me.ServiceHour - Me.TotalHours
80      End If
90   End If
100 End If
 
This is a fine point but an empty field in some cases means the same as 0 in other cases it means you have not entered or does not exist. By that, if you are tracking hours on all equipment then you could default totalhours to zero. However for service interval an empty field means you have not recorded it yet or it does not have a specified interval. Also a control bound to a numeric field cannot have an empty string in it so no need to check for that. Then this gets even cleaner.

Code: 
Private Sub Form_Load()
dim TotalHrs as long
dim ServInt as long

TotalHrs = nz(me.totalHours,0)
ServInt = nz(me.serviceInterval,0)

if not ServInt = 0 then
      me.divider = TotalHrs / ServInt 
      me.dueInValue = ServInt + nz(Me.ServiceHour,0) - TotalHrs
end sub
 
You have the code in the form's load event. So it runs only on the first record. I think you should be in the form's On Current event to run on each record. But more likely you need to call this in the after update of TotalHrs, ServInt, and ServiceHours. So make a general procedure so you can call "CalculateDueIn" from each of these events.
Code: 
Private Sub CalculateDueIn()
dim TotalHrs as long
dim ServInt as long

TotalHrs = nz(me.totalHours,0)
ServInt = nz(me.serviceInterval,0)

if not ServInt = 0 then
      me.divider = TotalHrs / ServInt
      me.dueInValue = ServInt + nz(Me.ServiceHour,0) - TotalHrs
end if
end sub
 
Sam Summers said:
Yes all the others seem to work but i may have found the mismatch
Click to expand...
In that case, I have another idea you could try, but I won't muddy the waters any further. Let us know how you get along with your current path. Cheers!
 
You must log in or register to reply here.

Similar threads

monheimx9
Generating QR Code for Access using the qr-rs library/CLI written in Rust
Replies
5
Views
2,511
DickyP
DickyP
F
A key for SHA1 Hashing
Replies
3
Views
671
freuzo
F
Sam Summers
Modal form not closing after code has run
Replies
8
Views
992
gemma-the-husky
gemma-the-husky
G
Solved Increment a value
Replies
3
Views
650
goncalo
G
C
Solved VBA loop issue
2
Replies
30
Views
1,691
Gasman
Gasman

Users who are viewing this thread

Total: 1 (members: 0, guests: 1)
Back
Top Bottom