command bar sub menu problems (1 Viewer)

[stuartam]

Can anyone help, i have written a "few" functions to allow me to create menus but when i try to add a button to a sub menu i get this error:

Run time error 5

invalid proceadure or call

any ideas, this has got me really stumped.

thanks

Function to create main menu bar

Public Function CreateMenu(MenuName As String)
    Dim menubar As CommandBar
    If fIsCreated(MenuName) Then
        Application.CommandBars(MenuName).Delete
    End If
    Set menubar = Application.CommandBars.Add(MenuName, msoBarTop, True, False)
    Application.CommandBars(MenuName).Visible = True
End Function

function to create menu popup items

Public Function AddMenuMainItem(MenuName As String, ItemType As String, ItemCaption As String, Optional OnAction As String)
    Dim menubar As CommandBar
    Dim MenuItem As CommandBarControl
    Set menubar = Application.CommandBars.ActiveMenuBar
    Set MenuItem = menubar.Controls.Add(msoControlPopup)
    MenuItem.Caption = ItemCaption
End Function

function to create buttons on popup menus

Public Function AddMenuSubItem(MenuName As String, MainItemName As String, ItemType As String, ItemCaption As String, ItemIcon As Long, Optional OnAction As String)
    Dim menubar As CommandBar
    Dim MenuItem As CommandBarButton
    Dim SubMenuItem As CommandBarPopup
    Dim mycontrol As CommandBarControl
    Select Case ItemType
        Case "msoControlButton"
            Set menubar = Application.CommandBars(MenuName)
            Set mycontroll = menubar.Controls(MainItemName)
            Set MenuItem = mycontroll.Controls.Add(msoControlButton)
            MenuItem.Caption = ItemCaption
            MenuItem.OnAction = OnAction
            MenuItem.Style = msoButtonAutomatic
            MenuItem.FaceId = ItemIcon
        Case "msoControlPopup"
            Set menubar = Application.CommandBars(MenuName)
            Set mycontroll = menubar.Controls(MainItemName)
            Set SubMenuItem = mycontroll.Controls.Add(msoControlPopup)
            SubMenuItem.Caption = ItemCaption
    End Select
End Function

creating the menu

Call CreateMenu("Main Menu1")
Call AddMenuMainItem("Main Menu1", "msoControlPopup", "&File")
Call AddMenuSubItem("Main Menu1", "&File", "msoControlButton", "&Print Screen", 4, "=docmd.printout")
Call AddMenuSubItem("Main Menu1", "&File", "msoControlButton", "&Edit", 463, "=docmd.quit")
Call AddMenuMainItem("Main Menu1", "msoControlPopup", "&popup2")
Call AddMenuSubItem("Main Menu1", "&popup2", "msoControlPopup", "&Batchs", 0)
Call AddMenuSubItem("Main Menu1", "&Batchs", "msoControlButton", "cap", 0, "=docmd.openform('frmcap')")

 

[MarkK]

What line causes the error? Do you know how to set breakpoints and step through code?

Your assignment to SubMenuItem references an object called mycontroll, (note the double trailing "ll") which does not appear to be declared anywhere.

 

[stuartam]

Thanks for the reply.
the error is here:

Set mycontrol = menubar.Controls(MainItemName)

when this line of code is called:

Call AddMenuSubItem("Main Menu1", "&Batchs", "msoControlButton", "cap", 0, "=docmd.openform('frmcap')")

i corrected the mycontroll mistype ( thanks for spotting it )

i will try and step through the code

thanks

 

[MarkK]

Don't know if you found it yet but this

Call AddMenuSubItem("Main Menu1", "&Batchs", "msoControlButton", "cap", 0, "=docmd.openform('frmcap')")

should be this

Call AddMenuSubItem("Main Menu1", [COLOR="DarkRed"]"&popup2"[/COLOR], "msoControlButton", "cap", 0, "=docmd.openform('frmcap')")

 

[stuartam]

thanks for the reply,

"&popup2" - is the popup menu on the main menu

"&Batchs" - is the popup menu on the "&popup2" menu

what i want is

Main menu
| |
File menu Popup2 > batch
bnt1 bnt1 btn1
bnt2 bnt2 btn2

hope that makes sence.

thanks for the help.

 

[MarkK]

Then I think you're going to need an AddMenuSubSubItem() routine which you haven't written yet, becuase this reference...

Set mycontrol = menubar.Controls("&popup2")

is going to need to resolve to one level deeper in the "menu tree"

Set mycontrol = menubar.Controls("&popup2").Controls("&Batchs")

See it?

One option is don't pass in strings like you're doing, but rather pass in the last object you created.

Public Function AddMenu(mName as string) as CommandBar
[COLOR="Green"]  'returns a menu object - delete routine omitted for clarity[/COLOR]
  Set AddMenu = CommandBars.Add(mName, msoBarTop, True, False)
End Function

Public Function AddPopup(cb as CommandBar, caption as string) as CommandBar
  Dim cbp as CommandBarPopup
  Set cbp = cb.controls.add(msoControlPopup)
  cbp.caption = caption
  Set AddPopup = cbp
End Function

Public Sub AddButton(cb as commandbar, caption as string, faceid as long, onaction as string) as CommandBarButton
  Dim cbb as CommandBarButton
  Set cbb = cb.Controls.Add(msoControlButton)
  With cbb
    .Caption = caption
    .OnAction = OnAction
    .Style = msoButtonAutomatic
    .FaceId = faceid
  End With
End Function

Now when you create the menu, hang on to your objects

Dim cb as commandbar
Dim cbp as commandbarpopup

[COLOR="Green"]'create the menu[/COLOR]
Set cb = AddMenu("Main1")
[COLOR="Green"]'add a popup to the menu[/COLOR]
Set cbp = AddPopup(cb, "&File")
[COLOR="Green"]'add buttons to the popup[/COLOR]
AddButton cbp, "&Print Screen", 4, "=docmd.printout"
AddButton cbp, "&Edit", 463, "=docmd.quit")
[COLOR="Green"]'add a popup to the menu[/COLOR]
Set cbp = AddPopup(cb, "&popup2")
[COLOR="Green"]'add a popup to the popup, not the menu[/COLOR]
Set cbp = AddPopup([COLOR="DarkRed"]cbp[/COLOR], "&Batchs")
[COLOR="Green"]'add button to the popup on the popup[/COLOR]
AddButton cbp, "cap", 0, "=docmd.openform('frmcap')"
[COLOR="Green"]'and you can use the .Parent property to navigate back to "&popup2"
'Set cbp = cbp.parent
[/COLOR]

I haven't tested any of this so beware, but you get the idea.

 

[stuartam]

thanks for the reply, i will have a go with it later today.

thanks again

 

[stuartam]

thanks

thanks it worked great. just have a new problems with combo boxes on menus in getting it to show the selected item in the onaction....

 

[IllusionRay]

Hello stuartam,

I am looking to create a MenuBar for a form and the information on the web is
very limited and vague, i was wondering if you still have the module you created, i was not sure how to put the code in this tread in module and form and if it was debug or not.

im using access 2016 not sure if it still compatible or not but i wish to try it so if you would be so kind to past the module code and form code in 2 block i would appreciate it greatly.

i hope that your still around.
Thx for your time!

 

[isladogs]

Stuartam was last here in sept 2007 so unlikely to reply.

Command bars were removed in Access 2007.
Newer version use the ribbon but this is MUCH harder to modify

 

[IllusionRay]

Yeah i have seen the ribbon setup but i don't really like it, my forms are all in popup mode and i hide the Access window so ppl see only what they need, i guess i will have to switch on c# in Visual studio so i can do what i want and not what i can lol

hoo well thx ridders for taking the time to answer here.

 

[MarkK]

You would still use CommandBars if you want a popup menu. I still use those on right click for things, like nodes in a treeview, but if your Access window is hidden you would also thereby hide your fixed position menu bars and toolbars.
Mark