Slow Code

[livvie]

The following piece of code is terribly slow in my app. How can I speed it up.
If Me.txtpartno = "" Then
MyPartName = Me.txtPartName
rstEst.Find "PartName = " & "'" & MyPartName & "'"
Else
MyPartno = Me.txtpartno
rstEst.Find "PartNo = " & "'" & MyPartno & "'"
End If

I have used the rst.Find method elsewhere on bigger tables and it's not as slow.

 

[KenHigg]

Have you tried indexing MyPartName?

kh

 

[livvie]

Have you tried indexing MyPartName?

kh

Thanks mate, everywhere else I use it I am searching on the PK field so the indexing was already done.
Thanks alot

 

[KenHigg]

How many records are there?

kh

 

[KenHigg]

This may not speed things up but you may want to loose some "&"s...

If Me.txtpartno = "" Then
MyPartName = Me.txtPartName
rstEst.Find "PartName = '" & MyPartName & "'"
Else
MyPartno = Me.txtpartno
rstEst.Find "PartNo = '" & MyPartno & "'"
End If


kh

 

[Mile-O]

This may not speed things up but you may want to loose some "&"s...

In this instance the speed gain wouldn't be noticeable. Concatenation, however, can slow processes.

 

[livvie]

How many records are there?

kh

25000 and growing. It's taking about 6 seconds.
I'll change the &'s

 

[KenHigg]

So you have your parts rs open and you want to find a part by part number or part name. Is this correct? I can see searching and finding a unique part number, but are the part names unique also? Seem's you could have multiple parts with the same name...

???
kh

 

[livvie]

So you have your parts rs open and you want to find a part by part number or part name. Is this correct? I can see searching and finding a unique part number, but are the part names unique also? Seem's you could have multiple parts with the same name...

???
kh

That's correct, the users tell me the part names are never the same but I'm not convinced. It makes it even more complicated when the partno or name can be blank.

 

[KenHigg]

1. What exactly does this pc of code do?

2. Seem's you could do a quick totals/count on part names in the table and present your argument against using this method...

kh

 

[livvie]

1. What exactly does this pc of code do?

2. Seem's you could do a quick totals/count on part names in the table and present your argument against using this method...

kh

This code is finding an estimate based on one selected on a form and then editing a field on this record . Maybe there is an easier way of doing it.